test: add unit tests for rolling file #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1996fanrui
force-pushed
the
34/rolling-file-test
branch
from
f0cfc57
to
7ec331f
Compare
1996fanrui
commented
Aug 10, 2024
tisonkun
reviewed
Aug 11, 2024
src/append/rolling_file/rotation.rs
Outdated
|
|
||
| /// Defines a fixed period for rolling of a log file. | ||
| #[derive(Clone, Eq, PartialEq, Debug)] | ||
| pub enum TimeRotation { |
There was a problem hiding this comment.
Let's keep the name Rotation as we don't introduce other rotation strategy. Also this is a public struct that changing its name would cause downstream software to migrate.
This PR adds tests only, and thus should avoid breaking changes.
tisonkun
reviewed
Aug 11, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
63
to
64
| cargo test -- --nocapture | ||
| cargo test --features rolling_file -- --nocapture |
There was a problem hiding this comment.
You can use --all-features, i.e.,
cargo test --all-features -- --nocapture
tisonkun
reviewed
Aug 11, 2024
src/append/rolling_file/rolling.rs
Outdated
| prefix: None, | ||
| suffix: None, | ||
| max_size: usize::MAX, | ||
| max_files: None, | ||
| clock: None, |
There was a problem hiding this comment.
Just default to DefaultClock?
There was a problem hiding this comment.
Updated, and I simplified the Clock related code as well.
tisonkun
reviewed
Aug 11, 2024
1996fanrui
force-pushed
the
34/rolling-file-test
branch
from
7ec331f
to
e8b34f3
Compare
1996fanrui
force-pushed
the
34/rolling-file-test
branch
from
e8b34f3
to
9b98068
Compare
Thanks for the review, all comments are addressed. And run |
tisonkun
reviewed
Aug 11, 2024
This was referenced Aug 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #34
Changes: